Allow building tests without benchmarks #545
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a
RE2_BUILD_NO_BENCHMARKSCMake option, which (in combination withRE2_BUILD_TESTING) makes it possible to build and run tests without also building and running benchmarks. The default behavior is unchanged in both theRE2_BUILD_TESTING=OFFandRE2_BUILD_TESTING=ONcases.This can be useful for people like Linux distribution packagers, who do want to run tests but do not necessarily care about benchmarks, and who might prefer to avoid the dependency on https://github.com/google/benchmark. (I maintain
re2in Fedora.)