Skip to content

Commit a43ee36

Browse files
committed
Apply review suggestions
1 parent c920d8f commit a43ee36

File tree

2 files changed

+3
-7
lines changed

2 files changed

+3
-7
lines changed

src/s2/s2region_term_indexer.cc

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -210,7 +210,6 @@ void S2RegionTermIndexer::GetIndexTermsForCanonicalCovering(
210210
: TermType::COVERING,
211211
id, prefix));
212212

213-
// If query only contains points, there are no need other terms.
214213
if (options_.query_contains_points_only()) continue;
215214

216215
if (!options_.optimize_for_space() && !is_max_level_cell) {

src/s2/s2region_term_indexer_test.cc

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,7 @@ S2_DEFINE_int32(iters, 400, "number of iterations for testing");
4646

4747
namespace {
4848

49-
enum DataType {
50-
POINT = 0,
51-
CAP = 1,
52-
};
49+
enum DataType { POINT, CAP };
5350

5451
void TestRandomCaps(const S2RegionTermIndexer::Options& options,
5552
DataType index_type, DataType query_type) {
@@ -180,12 +177,12 @@ TEST_P(S2RegionTermIndexerTest, ConstrainMinMaxLevels) {
180177

181178
TEST_P(S2RegionTermIndexerTest, UseLeafCells) {
182179
options.set_min_level(4);
183-
options.set_max_level(S2CellId::kMaxLevel);
180+
options.set_max_level(S2CellId::kMaxLevel); // Use leaf cells.
184181
options.set_max_cells(8);
185182
TestRandomCaps(options, index_type, query_type);
186183
}
187184

188-
TEST_P(S2RegionTermIndexerTest, UseFaceCells2) {
185+
TEST_P(S2RegionTermIndexerTest, UseFaceCellsCustomLevelMode) {
189186
options.set_min_level(0);
190187
options.set_max_level(S2CellId::kMaxLevel);
191188
options.set_level_mod(2);

0 commit comments

Comments
 (0)