Improvements #296
Closed
Improvements #296
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add ability to reuse term buffer * Add option for optimize index size if query only points
MBkkt
commented
Jan 6, 2023
| } | ||
| if (level == true_max_level || !options_.optimize_for_space()) { | ||
| // Add an ancestor term for this cell at the constrained level. | ||
| terms.push_back(GetTerm(TermType::ANCESTOR, id.parent(level), prefix)); |
There was a problem hiding this comment.
id.parent(level) == id is always true here because level == id.level() see old line 177 (or new 192)
|
Having 6 PRs in 1 will quickly become unwieldy. Please split up future PRs for easier disucssion. |
Will be done |
|
Yeah let's split this one up we can probably submit the others separate from the term indexer one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve s2region_term_indexer:
Add access to coverer
Add access to S2Polygon::subregion_bound_
Add S2_SYSTEM_HEADERS cmake options to avoid s2 compile time warnings from s2 headers
Add S2_INSTALL option with keeping old behavior
Needs tests run! PR now mostly for discussion.