Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build library and also Python wheels in CI #390
base: master
Are you sure you want to change the base?
build library and also Python wheels in CI #390
Changes from all commits
bf8cf9a
59b63a5
e166179
feee1a3
9614d07
7649588
f173b27
306cb49
5426608
18b3139
a2c8a64
3cdefa4
ab525c0
d3df01d
fdfcd74
d2ce2ac
cb65e68
a26cf9d
a0924ea
bd5f6b3
8330fdc
9108afb
aacb92e
726306f
3cef06a
0446b38
74a0e88
f97d130
6322abf
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's using this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was using this to test whether inserting
GOOGLETEST_ROOT
into the cmake options would solve the segfault; I can remove it if desiredThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, just revert this file unless you really need the changes.