-
Notifications
You must be signed in to change notification settings - Fork 340
exactfloat: Remove OpenSSL dependency #453
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
smcallis
wants to merge
33
commits into
google:master
Choose a base branch
from
smcallis:remove-openssl
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
33 commits
Select commit
Hold shift + click to select a range
6e1ea2a
Add bignum.h and port exactfloat to use it.
smcallis f84d63c
Rework Karatsuba and respond to PR comments.
smcallis 20f683f
Address round 2 CR comments.
smcallis d05deac
Address PR Round 3 comments.
smcallis 4552c91
Fix Karatsuba for highly asymmetric operand sizes.
smcallis df3de50
Remove assignment operator.
smcallis 145c441
PR round 4 fixes.
smcallis bcf22c0
PR (Mega) round 5 changes.
smcallis eb02a46
PR (Mega) Round 5 more changes.
smcallis 670e946
PR Round 7 changes.
smcallis 8485aec
Cleanup util/math BUILD file and ensure clean compilation and run.
smcallis 8b1cafb
Remove final usage of ssize_t.
smcallis 08d1991
Add exactfloat_test to BUILD file.
smcallis ec5c313
Use int64_t instead of int for size casts out of an abundance of caut…
smcallis e7a4cb7
Split INT_MIN construction test case into a separate named case.
smcallis 82d89d7
Fix typo in bignum.cc.
smcallis b363023
Add comment for the Numbers() function.
smcallis d3db3f6
Create tagged seed sequences for bignum tests and minor fixes.
smcallis 906afdc
CR Round 7 fixes.
smcallis c118358
CR round 8 changes.
smcallis 54508e3
Minor renaming and comment fixes.
smcallis 0d6ccf4
Remove redundant borrow propagation loop.
smcallis 50c9922
Revert .bazelrc changes.
smcallis 83e5b3c
Minor formatting cleanup.
smcallis a54f63f
Revert to using find_package for OpenSSL.
smcallis 7d40d30
Remove 0 - term when static_cast-ing INT_MIN to take absolute value.
smcallis eb90050
Make find_package(OpenSSL) test-only and minor fixups.
smcallis 7c3dcd7
Minor spacing fixes and more comments on AddBigit and MulAddBigit.
smcallis 7494306
Minor edits.
smcallis edfc034
Add SafeAbs to avoid UB when casting INT_MIN.
smcallis 30ab250
Change is_normal calls to isnormal().
smcallis ee70a74
Remove old //s2//base:port dependency from exactfloat.
smcallis d46c2e9
CR round 9 minor changes.
smcallis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.