Skip to content

Conversation

@ivan-gerasimov
Copy link

Hi team,

This pull request adds the source code for the s2geometry.io website. The goal is to migrate the site to a Google-controlled repository. This will allow us to fix the HTTPS certificate issue and resolve the "Not Secure" browser warning.

Directory Choice: /docs

The website source files have been placed in the /docs directory.

I understand that having both a /doc and a /docs directory might seem a bit confusing. The /docs directory was chosen because this is the standard folder name that GitHub Pages uses to publish a website from the master branch.

We can discuss changing this structure in the future if the current arrangement is inconvenient for the team.

Next Steps

After this PR is merged, the s2geometry.io custom domain can be configured in the repository settings to serve from this /docs folder, and the DNS records can be updated.

Thanks!

@ivan-gerasimov ivan-gerasimov marked this pull request as draft November 27, 2025 01:26
@ivan-gerasimov
Copy link
Author

@jmr, @eengle can you please take a look at your convenience?

@ivan-gerasimov ivan-gerasimov marked this pull request as ready for review November 27, 2025 01:30
@jmr
Copy link
Member

jmr commented Nov 27, 2025

These should really be added back to the util/geometry/opensource export. Most (all?) of these files exist in util/geometry/g3doc/. It's just going to cause problems to add them separately.

// Copyright 2017 Google Inc. All Rights Reserved.
// Author: [email protected] (Eric Veach)
//
// This example shows how to add spatial data to an information retrieval
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We already have https://github.com/google/s2geometry/blob/master/doc/examples/term_index.cc.

These trees need to be unified more carefully.

@@ -0,0 +1,28 @@
source "https://rubygems.org"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this Gemfile here?

@@ -0,0 +1,204 @@
Apache License
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is another license being added?

@jmr jmr changed the title feat: Add s2geometry.io website source Add s2geometry.io website source from github.com/manshreck/s2geometry.github.io Nov 27, 2025
@benguild
Copy link

#473 related

@jmr
Copy link
Member

jmr commented Dec 2, 2025

What's with the CNAME changes? Why is CNAME being deleted?

@ivan-gerasimov
Copy link
Author

What's with the CNAME changes? Why is CNAME being deleted?

Hi @jmr,

Good question. The CNAME file is managed by GitHub's Pages service. It was automatically deleted when the custom domain in the repository settings was explicitly cleared.

GitHub will auto-generate the CNAME file again once "s2geometry.io" is set as the custom domain in the settings for the repository that will host the live site.

This action is currently blocked because the domain is still associated with the old "manshreck/s2geometry.github.io" repository. After that association is removed, we can configure the domain here and the file will be automatically populated by GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants