This repository was archived by the owner on Dec 29, 2022. It is now read-only.
Builtin: push a Frame on the Thread's stack even when calling Builtins #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes the stack trace more accurate. Breaking API change: (*Frame).Function is superseded by (*Frame).Callable.
jayconrod
approved these changes
Jul 2, 2018
| } | ||
|
|
||
| // Function returns the frame's function, or nil for the top-level of a module. | ||
| func (fr *Frame) Function() *Function { return fr.fn } | ||
| var builtinFilename = "<builtin>" |
There was a problem hiding this comment.
Nit: const instead of var?
There was a problem hiding this comment.
It must be a variable as we needs its address on line 131. (The reason the variable is global, not local to that function, is to avoid allocating it more than once.)
eval_test.go
Outdated
| @@ -167,7 +167,8 @@ func load(thread *skylark.Thread, module string) (skylark.StringDict, error) { | |||
| } | |||
|
|
|||
| // TODO(adonovan): test load() using this execution path. | |||
| filename := filepath.Join(filepath.Dir(thread.Caller().Position().Filename()), module) | |||
| filename := filepath.Join(filepath.Dir(thread. | |||
There was a problem hiding this comment.
Seems like an odd place to break the line. Was it too long before? Extracting the directory into a variable might be slightly better.
There was a problem hiding this comment.
This newline was introduced by mistake; removed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the stack trace more accurate.
Breaking API change: (*Frame).Function is superseded by (*Frame).Callable.