RFC: syz-cluster: consider git diffs during series triage #5934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip the series if it only modifies the file types that are assumed to be irrelevant for the kernel build outcome.
dvyukov
reviewed
Apr 11, 2025
| ".txt": true, | ||
| ".rst": true, | ||
| ".json": true, | ||
| ".py": true, |
There was a problem hiding this comment.
There are some codegen scripts in Python, at least I see "gen_header.py".
json/txt may be inputs to these scripts.
| "github.com/google/syzkaller/syz-cluster/pkg/api" | ||
| ) | ||
|
|
||
| // For now, follow the simplest strategy - just verify whether the series modifies only the files |
There was a problem hiding this comment.
Add a TODO that this should be replaced with build signatures, rather than extended be more and more complex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've moved this commit out of #5924 to merge #5924 faster.
Skip the series if it only modifies the file types that are assumed to be irrelevant for the kernel build outcome.