-
Notifications
You must be signed in to change notification settings - Fork 1.3k
pkg/ifaceprobe: note error only when res.Err is not null #6021
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
73ada06
to
f48d65e
Compare
What are the cases when |
This is one kind of error:
|
Seeing iface-probe run exits abnormally: ``` [FATAL] interface probing failed: failed to execute prog: %!w(<nil>) (Crashed) r0 = openat(0xffffffffffffff9c, &(0x7f0000000080)='/sys/devices/pci0000:00/0000:00:01.1/ ata1/host0/target0:0:0/0:0:0:0/block/sda/queue/scheduler', 0x1, 0x0) write(r0, &(0x7f0000000100)=' ', 0x1) exit status 1 ``` The node to have this `%!w(nil>) (Crashed)` is random, but continue when res.Err is null bypass the problem.
The fact that the kernel crashed when the tool was probing an interface does seem to me like a valid case for reporting an error. Otherwise we will get different descriptions each run depending on what programs were not properly executed. Cc @dvyukov who wrote this code. |
I don't know what's the best answer here. Both failing the tool and ignoring the kernel bug bad. Ideally of course kernel does not crash on such simple actions like opening a file. One recommendation when running the tool is to add this to the manager config:
And maybe configuring the kernel w/o most debugging configs (it only needs KCOV). |
Hi @dvyukov ,
and disabled CONFIG_KASAN, still see this
can you share your .config and manager.cfg, I'm currently using dashboard/config/linux/upstream-apparmor-kasan.config without CONFIG_KASAN. I also tried defconfig, however it will enter into rescue mode (no network) when starting bullseye.img. |
I did not record exact kernel revision/config, etc. But also used something similar to dashboard/config/linux/upstream-apparmor-kasan.config. If looks like your kernel/VM is somehow mis-configured based on very frequent "no output from test machine". Do you run qemu w/o KVM by any chance? Does syz-manager work fine with this exact config? |
Before sending a pull request, please review Contribution Guidelines:
https://github.com/google/syzkaller/blob/master/docs/contributing.md