This repository has been archived by the owner on Nov 30, 2023. It is now read-only.
Switch to absolute imports for Python3 compatability #460
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Another backwards compatible change as part of google#412 by running: futurize -nw -f libfuturize.fixes.fix_print_with_import .
Part of google#412 Started by: futurize -nw -f libfuturize.fixes.fix_absolute_import . And followed up by fixing a few local problems.
jarondl
added a commit
to jarondl/transitfeed
that referenced
this pull request
Jan 28, 2019
Part of google#412 Started with `futurize -nw --stage1 .`, but had to do a few manual changes. Note that it includes commits from google#460
transitfeed has many import cycles, which is a bad thing. Converting to absolute import exposed some of them. This changes adds the minimal changes required to make imports work, for example by moving some types from `problems.py` to `errors.py`.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #412
Started by:
futurize -nw -f libfuturize.fixes.fix_absolute_import .
And followed up by fixing a few local problems.
Note that it includes commits that are part of #457, so we should merged #457 first