Skip to content
This repository has been archived by the owner on Nov 30, 2023. It is now read-only.

python3 porting #491

Closed
wants to merge 11 commits into from
Closed

python3 porting #491

wants to merge 11 commits into from

Conversation

pecalleja
Copy link

Python3 porting with all tests running ok.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@pecalleja
Copy link
Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@jarondl
Copy link
Contributor

jarondl commented Oct 10, 2019

This is one git commit with 99 files and git status of +29,726 −24,238

I cannot review such a thing. I don't think anyone can read 60K lines of changes.

@avilaton and me started Python3 porting in smaller steps. If you can contribute small, reviewable changes, that would be welcome. Most auto-porting tools (which I assume you used), allow to apply only partial transformations, by choosing which transformers to apply.

@googlebot
Copy link

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@pecalleja
Copy link
Author

@googlebot I consent.

@pecalleja
Copy link
Author

Sorry for my mistake, I just wanted to help to make this port. How can I fix my mistake? Currently, all tests for Python 3.7 are already running. how can I go forward with the collaboration?

@pecalleja pecalleja mentioned this pull request Oct 12, 2019
@pecalleja
Copy link
Author

at least can we have a separate branch for python3 support ?

@jarondl
Copy link
Contributor

jarondl commented Oct 28, 2019

How would we maintain that branch? Do you plan to submit every change to master to this branch too?
Let's update master to python3, but piece by piece. See #412

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants