Refer to the actual value as "the actual value," not as "the subject." #1454
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
(#203) I considered instead using phrases like "the string," we [sometimes already do](https://github.com/google/truth/blob/0337b58cf7ca53d89d9badb56d7467c8576f8aa4/core/src/main/java/com/google/common/truth/StringSubject.java#L99). But I worried that that wasn't always immediately clear about whether we're talking about the actual value or some parameter of the assertion method (which is an expected value or similar). Not that I cared about this _enough_ to go back and change existing occurrences.... This CL probably covers all remaining occurrences in core Truth. I haven't looked at our extensions or our tests. RELNOTES=n/a PiperOrigin-RevId: 766689205
copybara-service
bot
force-pushed
the
test_766683922
branch
from
9b46d3f to
2aad319
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refer to the actual value as "the actual value," not as "the subject."
(#203)
I considered instead using phrases like "the string," we sometimes already do. But I worried that that wasn't always immediately clear about whether we're talking about the actual value or some parameter of the assertion method (which is an expected value or similar). Not that I cared about this enough to go back and change existing occurrences....
This CL probably covers all remaining occurrences in core Truth. I haven't looked at our extensions or our tests.
RELNOTES=n/a