Say "Checks that _x_," not "Fails if _!x_."#1458
Merged
copybara-service[bot] merged 1 commit intomasterfrom Jun 3, 2025
Merged
Say "Checks that _x_," not "Fails if _!x_."#1458copybara-service[bot] merged 1 commit intomasterfrom
copybara-service[bot] merged 1 commit intomasterfrom
Conversation
We've moved a bit in this direction over the years, and now I'm trying to push us the rest of the way. I did most of this with regex search and replace, so it's likely that I've introduced the sorts of errors you might expect from that (in addition to whatever errors I have introduced by hand :)). To aid the automation, I did end up stamping out phrases like "Checks that _the string_...," as previously discussed in cl/766689205... only to reintroduce them for _some_ types. I hope that we are at least now largely consistent within a given type. Just to make things interesting, I've tweaked phrasing in a few other ways. The most notable change is to back out some discussion of duplicates from methods like `containsNoneOf`. That discussion was introduced in cl/130379377, so of course push back if it seems worth keeping. RELNOTES=n/a PiperOrigin-RevId: 766810480
copybara-service
bot
force-pushed
the
test_766761586
branch
from
6cdf3e8 to
197f633
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Say "Checks that x," not "Fails if !x."
We've moved a bit in this direction over the years, and now I'm trying to push us the rest of the way.
I did most of this with regex search and replace, so it's likely that I've introduced the sorts of errors you might expect from that (in addition to whatever errors I have introduced by hand :)). To aid the automation, I did end up stamping out phrases like "Checks that the string...," as previously discussed in cl/766689205... only to reintroduce them for some types. I hope that we are at least now largely consistent within a given type.
Just to make things interesting, I've tweaked phrasing in a few other ways. The most notable change is to back out some discussion of duplicates from methods like
containsNoneOf. That discussion was introduced in cl/130379377, so of course push back if it seems worth keeping.RELNOTES=n/a