Jules WIP: Refactor constructors to static factory methods. #1460
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… done so far and provide feedback for Jules to continue.
Made constructors private and introduced package-private static factory methods for the following classes: - Transforming in com.google.common.truth.Correspondence - ComparisonFailureWithFacts in com.google.common.truth.ComparisonFailureWithFacts (including GWT-specific version and reflective call site) - ComparisonResult in com.google.common.truth.Subject - MapInOrder in com.google.common.truth.MapSubject - StoredException in com.google.common.truth.Correspondence All internal constructor call sites within their respective parent classes have been updated to use the new factory methods.
This commit refactors a number of nested classes to use private constructors and package-private static factory methods. The following classes were updated: - FormattingDiffs in com.google.common.truth.Correspondence - FromBinaryPredicate in com.google.common.truth.Correspondence - HopcroftKarp in com.google.common.truth.GraphMatching - IterableEntries in com.google.common.truth.MultimapSubject - NonHashingMultiset in com.google.common.truth.SubjectUtils - Pairer in com.google.common.truth.IterableSubject - Pairing in com.google.common.truth.IterableSubject - TolerantNumericEquality in com.google.common.truth.Correspondence - ValueDifference in com.google.common.truth.MapSubject - DoubleArrayAsIterable in com.google.common.truth.PrimitiveDoubleArraySubject - DuplicateGroupedAndTyped in com.google.common.truth.SubjectUtils - FloatArrayAsIterable in com.google.common.truth.PrimitiveFloatArraySubject - LazyMessage in com.google.common.truth.LazyMessage (including external call sites) - MultimapInOrder in com.google.common.truth.MultimapSubject - TolerantDoubleComparison in com.google.common.truth.DoubleSubject - TolerantFloatComparison in com.google.common.truth.FloatSubject - TolerantIntegerComparison in com.google.common.truth.IntegerSubject - TolerantLongComparison in com.google.common.truth.LongSubject - Transforming in com.google.common.truth.Correspondence - ComparisonFailureWithFacts in com.google.common.truth.ComparisonFailureWithFacts (including GWT-specific version and reflective call in Platform.java) - ComparisonResult in com.google.common.truth.Subject - MapInOrder in com.google.common.truth.MapSubject - StoredException in com.google.common.truth.Correspondence - UsingCorrespondence in com.google.common.truth.MapSubject - UsingCorrespondence in com.google.common.truth.MultimapSubject The constructors of these classes were made private, and package-private static factory methods (usually named 'create') were introduced to encapsulate object creation. All internal and relevant external call sites were updated to use these factory methods. This change improves encapsulation and provides a clear entry point for instantiation, potentially allowing for future flexibility in object creation (e.g., caching, subclassing with different strategies) without altering the public API of the factory method. Two classes, SortedMapAsNavigableMap and SortedSetAsNavigableSet, were skipped as they were confirmed to be obsolete. The UsingCorrespondence class within IterableSubject.java was also skipped as per your specific request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.