Start migration to Kotlin #55
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucianbc
force-pushed
the
kt-transition
branch
2 times, most recently
from
a836bb6
to
cd103ad
Compare
lucianbc
force-pushed
the
kt-transition
branch
from
cd103ad
to
147656a
Compare
garanj
approved these changes
Nov 12, 2024
| var ambientLimitBytes: Long = MemoryFootprint.toBytes(10.0) | ||
| private set | ||
| /** The memory limit in bytes for the active mode. Defaults to 10 * 10^20 bytes (or 10 MB). */ | ||
| var activeLimitBytes: Long = MemoryFootprint.toBytes(10.0) |
There was a problem hiding this comment.
A developer made the comment recently, is it sensible to change this default to 100, to align with the Play default? Is it worth doing this as part of the migration?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.