[DSLX] use syntax: enable using a module.
#1924
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdleary
force-pushed
the
cdleary/2025-02-10-ability-to-use-modules
branch
3 times, most recently
from
ec95343 to
1c69fbc
Compare
richmckeever
approved these changes
Feb 12, 2025
cdleary
force-pushed
the
cdleary/2025-02-10-ability-to-use-modules
branch
2 times, most recently
from
9112d27 to
bae2348
Compare
Then we can colon-ref off of it. The type of a module reference is an existential wrapper of the module identity itself. This lets us keep type information for the AST node in the TypeInfo mapping without having a "hole" where an AST node has no associated type information.
cdleary
force-pushed
the
cdleary/2025-02-10-ability-to-use-modules
branch
from
bae2348 to
4d83081
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
analogous (but more powerful than) import, e.g.
and
Then we can colon-ref off of that module name.
The type of a module reference is an existential wrapper of the module identity itself. This lets us keep type information for the AST node in the TypeInfo mapping without having a "hole" where an AST node has no associated type information.
Implementation-wise this mostly means that
UseTreeEntry*nodes have to ride the same pathways thatImport*nodes were already riding in order to resolve module attributes.