[DSLX:tests] Add sample showing std::find_index on enum array. #1931
+51
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grebe
approved these changes
Feb 14, 2025
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| //! Validates that we can find the index of a value in an enum array. |
There was a problem hiding this comment.
Is //! for some reason I'm unaware of?
There was a problem hiding this comment.
For rustdoc this means "it's a comment block associated with the module it's enclosed in" -- we don't have a dslxdoc yet but I hope to fix that one day so just trying to stick to what we'd tend to do in Rust where possible.
No worries I usually just post it in draft form to make sure CI passes before I hit the "ready" button. |
grebe
approved these changes
Feb 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Demonstrates how we can use
std::find_indexif we map over the enum array to convert into the underlying type first, since we can't currently (with TIv1) write a stdlib routine that's parameterized over both enum types and bit values.