Improve hash memory management #106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Small speed when running a lot of iterations Before: real 13m55.064s user 13m54.610s sys 0m0.180s After: real 13m48.580s user 13m48.555s sys 0m0.010s * tested on Odroid U3 O/C 1.92Ghz, 5000 iterations on old lodepng.cpp sourcecode file.
|
Technically, you are not guaranteed that int is using two's-complement, so you cannot set them to -1 using memset. I know it will likely be hard to find a platform where this is not the case, but perhaps it is better to stay on the safe side of the standard if the improvement is so relatively small? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before:
real 13m55.064s
user 13m54.610s
sys 0m0.180s
After:
real 13m48.580s
user 13m48.555s
sys 0m0.010s
sourcecode file. Default makefile used.
The speed improvement should be greater when Hash Same Hash is enabled.