Fix bug in normalize_and_hash_email_address function #752
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit
If
email_address
has no"@"
in it, the function raisesIndexError list index out of range
in:because
email_parts
is a list with only one item.This PR fix this bug by moving the above line inside the if-block
if len(email_parts) > 1
.Second commit
I've added
strip
toemail_address
to honor the Enhanced Conversions doc which says: