Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow change pool time seconds at WaitForReport. #554

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Allow change pool time seconds at WaitForReport. #554

wants to merge 2 commits into from

Conversation

gbretas
Copy link

@gbretas gbretas commented Nov 2, 2024 •
edited
Loading

Related to issue #508 and #465.

@gbretas
Copy link
Author

gbretas commented Nov 2, 2024

This pull request includes a modification to the WaitForReport method in the googleads/ad_manager.py file to allow customization of the polling interval. The most important changes include adding a new parameter for the polling interval and updating the sleep function to use this new parameter.

Enhancements to WaitForReport method:

  • googleads/ad_manager.py: Added pollTimeSeconds parameter to the WaitForReport method to allow customization of the polling interval. Updated the docstring to reflect this change.
  • googleads/ad_manager.py: Updated the time.sleep call within the WaitForReport method to use the new pollTimeSeconds parameter instead of a hardcoded value.

@gbretas
Copy link
Author

gbretas commented Nov 2, 2024

Changed the variable at PR @christopherseeley.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherseeley christopherseeley christopherseeley left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbretas @christopherseeley