Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Create/Pass commit date to commit for signing #485

Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat: Create/Pass commit date to commit for signing #485

wants to merge 6 commits into from

Conversation

IchordeDionysos
Copy link

@IchordeDionysos IchordeDionysos commented Jan 30, 2024 •
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #337 🦕

@IchordeDionysos IchordeDionysos requested review from a team as code owners January 30, 2024 16:34
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Jan 30, 2024
@IchordeDionysos IchordeDionysos mentioned this pull request Jan 30, 2024
Open
@IchordeDionysos IchordeDionysos changed the title Create/Pass commit date to commit for signing feat: Create/Pass commit date to commit for signing Jan 30, 2024
@conventional-commit-lint-gcf Conventional Commit Lint GCF
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jan 30, 2024
@IchordeDionysos IchordeDionysos mentioned this pull request Feb 19, 2024
Open
@IchordeDionysos
Copy link
Author

@googleapis/github-automation can someone review my PR, this would unblock issues in release-please to sign commits.

@IchordeDionysos
Copy link
Author

There is some open/related discussion in this issue:
#337 (comment)

also /cc @chingor13 @SurferJeffAtGoogle

@IchordeDionysos
Copy link
Author

@chingor13 @SurferJeffAtGoogle @bshaffer hey it would be cool to get some feedback whether this is something we can add to the package.

As it is currently the commit signing capability is broken and does not work ...

@IchordeDionysos
Copy link
Author

@sofisl @danieljbruce do you see any possibility to get this merged? ☺️
This would unblock using release-please in situations where commit signing is required.

@chingor13 chingor13 closed this Oct 25, 2024
@chingor13 chingor13 reopened this Oct 25, 2024
@chingor13 chingor13 closed this Feb 26, 2025
@chingor13 chingor13 reopened this Feb 26, 2025
chingor13
chingor13 requested changes Feb 27, 2025
View reviewed changes
Copy link
Contributor

@chingor13 chingor13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we're finally getting back to PRs on this repo.

The tests are not passing and this branch is not writeable so we can't help update it

src/types.ts
@@ -206,6 +206,7 @@ export interface Logger {
export interface UserData {
name: string;
email: string;
date?: Date;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think I follow why date is part of the UserData as opposed to the commit

src/types.ts
export interface CommitSigner {
generateSignature(commit: CommitData): Promise<string>;
generateSignature(commit: CommitDataWithRequiredDate): Promise<string>;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like a breaking change which makes additional inputs required. Does this actually need to be a required field?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chingor13 chingor13 chingor13 requested changes

@Sese-Schneider Sese-Schneider Sese-Schneider approved these changes

Requested changes must be addressed to merge this pull request.

Assignees

@chingor13 chingor13

Labels
size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add GPG Signature option
3 participants
@IchordeDionysos @chingor13 @Sese-Schneider