chore: return error for untested fields in tools.yaml #239
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Yuan325
force-pushed
the
yaml-update
branch
6 times, most recently
from
2d6747f to
d359b51
Compare
kurtisvg
approved these changes
Feb 3, 2025
kurtisvg
approved these changes
Feb 3, 2025
jeffreyrubi
pushed a commit
to jeffreyrubi/genai-toolbox
that referenced
this pull request
Jun 7, 2025
Tested locally to confirm the changes resolve the issue. Working as expected,
jeffreyrubi
pushed a commit
to jeffreyrubi/genai-toolbox
that referenced
this pull request
Jun 7, 2025
This only checks within `SourceConfig`, `ToolConfig`, and `AuthSourceConfig`. Error when an unknown field is provided: `2025-01-27T22:43:46.988401-08:00 ERROR "unable to parse tool file at \"tools.yaml\": unable to parse as \"cloud-sql-postgres\": [2:1] unknown field \"extra\"\n 1 | database: test_database\n> 2 | extra: here\n ^\n 3 | instance: toolbox-cloudsql\n 4 | kind: cloud-sql-postgres\n 5 | password: postgres\n 6 | "` Error when a required field is not provided: `2025-01-27T17:49:47.584846-08:00 ERROR "unable to parse tool file at \"tools.yaml\": validation failed: Key: 'Config.Region' Error:Field validation for 'Region' failed on the 'required' tag"` --------- Co-authored-by: Kurtis Van Gent <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This only checks within
SourceConfig,ToolConfig, andAuthSourceConfig.Error when an unknown field is provided:
2025-01-27T22:43:46.988401-08:00 ERROR "unable to parse tool file at \"tools.yaml\": unable to parse as \"cloud-sql-postgres\": [2:1] unknown field \"extra\"\n 1 | database: test_database\n> 2 | extra: here\n ^\n 3 | instance: toolbox-cloudsql\n 4 | kind: cloud-sql-postgres\n 5 | password: postgres\n 6 | "Error when a required field is not provided:
2025-01-27T17:49:47.584846-08:00 ERROR "unable to parse tool file at \"tools.yaml\": validation failed: Key: 'Config.Region' Error:Field validation for 'Region' failed on the 'required' tag"