Skip to content

fix(postgres,mssql,cloudsqlmssql)!: encode source connection url for sources #727

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 18, 2025
Merged

fix(postgres,mssql,cloudsqlmssql)!: encode source connection url for sources #727

merged 2 commits into from
Jun 18, 2025

Conversation

Yuan325
Copy link
Contributor

@Yuan325 Yuan325 commented Jun 17, 2025 •
edited
Loading

Have to encode special character in connection url. Only needed for postgres, mssql, cloud-sql-mssql sources.

Fixes #717

@Yuan325 Yuan325 requested a review from a team as a code owner June 17, 2025 23:24
@Yuan325 Yuan325 force-pushed the fix-connection-url branch 4 times, most recently from 6fdcab5 to 7f28dd5 Compare June 18, 2025 01:33
@Yuan325 Yuan325 changed the title fix: encode source connection url fix!: encode source connection url Jun 18, 2025
@Yuan325 Yuan325 changed the title fix!: encode source connection url fix!(cloud-sql-mssql/cloud-sql-mysql/mssql/mysql/postgres): encode source connection url Jun 18, 2025
@Yuan325 Yuan325 changed the title fix!(cloud-sql-mssql/cloud-sql-mysql/mssql/mysql/postgres): encode source connection url fix!: encode source connection url for cloudsqlmssql, cloudsqlmysql, mssql, mysql, and postgres sources Jun 18, 2025
@Yuan325 Yuan325 changed the title fix!: encode source connection url for cloudsqlmssql, cloudsqlmysql, mssql, mysql, and postgres sources fix!: encode source connection url for postgres, mysql, mssql, cloudsqlmssql, cloudsqlmysql sources Jun 18, 2025
@Yuan325 Yuan325 changed the title fix!: encode source connection url for postgres, mysql, mssql, cloudsqlmssql, cloudsqlmysql sources fix(postgres,mysql,mssql,cloudsqlmssql,cloudsqlmysql)!: encode source connection url for sources Jun 18, 2025
@Yuan325 Yuan325 force-pushed the fix-connection-url branch from bb5efef to b853690 Compare June 18, 2025 22:28
@Yuan325 Yuan325 force-pushed the fix-connection-url branch from b853690 to 42534b3 Compare June 18, 2025 22:28
@Yuan325 Yuan325 changed the title fix(postgres,mysql,mssql,cloudsqlmssql,cloudsqlmysql)!: encode source connection url for sources fix(postgres,mssql,cloudsqlmssql)!: encode source connection url for sources Jun 18, 2025
@Yuan325 Yuan325 merged commit 67964d9 into main Jun 18, 2025
8 checks passed
@Yuan325 Yuan325 deleted the fix-connection-url branch June 18, 2025 22:32
@release-please release-please bot mentioned this pull request Jun 18, 2025
Merged
duwenxin99 pushed a commit to dennisg/genai-toolbox that referenced this pull request Jul 1, 2025
@Yuan325 @duwenxin99
fix(postgres,mssql,cloudsqlmssql)!: encode source connection url for …
1936313 
…sources (googleapis#727)

Have to encode special character in connection url. Only needed for
`postgres`, `mssql`, `cloud-sql-mssql` sources.

Fixes googleapis#717
Yuan325 added a commit that referenced this pull request Jul 2, 2025
@release-please @Yuan325
chore(main): release 0.8.0 (#689)
f13e963 
🤖 I have created a release *beep* *boop*
---


##
[0.8.0](v0.7.0...v0.8.0)
(2025-07-02)


### ⚠ BREAKING CHANGES

* **postgres,mssql,cloudsqlmssql:** encode source connection url for
sources ([#727](#727))

### Features

* Add support for multiple YAML configuration files
([#760](#760))
([40679d7](40679d7))
* Add support for optional parameters
([#617](#617))
([4827771](4827771)),
closes [#475](#475)
* **mcp:** Support MCP version 2025-03-26
([#755](#755))
([474df57](474df57))
* **sources/http:** Support disable SSL verification for HTTP Source
([#674](#674))
([4055b0c](4055b0c))
* **tools/bigquery:** Add templateParameters field for bigquery
([#699](#699))
([f5f771b](f5f771b))
* **tools/bigtable:** Add templateParameters field for bigtable
([#692](#692))
([1c06771](1c06771))
* **tools/couchbase:** Add templateParameters field for couchbase
([#723](#723))
([9197186](9197186))
* **tools/http:** Add support for HTTP Tool pathParams
([#726](#726))
([fd300dc](fd300dc))
* **tools/redis:** Add Redis Source and Tool
([#519](#519))
([f0aef29](f0aef29))
* **tools/spanner:** Add templateParameters field for spanner
([#691](#691))
([075dfa4](075dfa4))
* **tools/sqlitesql:** Add templateParameters field for sqlitesql
([#687](#687))
([75e254c](75e254c))
* **tools/valkey:** Add Valkey Source and Tool
([#532](#532))
([054ec19](054ec19))


### Bug Fixes

* **bigquery,mssql:** Fix panic on tools with array param
([#722](#722))
([7a6644c](7a6644c))
* **postgres,mssql,cloudsqlmssql:** Encode source connection url for
sources ([#727](#727))
([67964d9](67964d9)),
closes [#717](#717)
* Set default value to field's type during unmarshalling
([#774](#774))
([fafed24](fafed24)),
closes [#771](#771)
* **server/mcp:** Do not listen from port for stdio
([#719](#719))
([d51dbc7](d51dbc7)),
closes [#711](#711)
* **tools/mysqlexecutesql:** Handle nil panic and connection leak in
Invoke ([#757](#757))
([7badba4](7badba4))
* **tools/mysqlsql:** Handle nil panic and connection leak in invoke
([#758](#758))
([cbb4a33](cbb4a33))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan <[email protected]>
github-actions bot pushed a commit that referenced this pull request Jul 2, 2025
@Yuan325 @release-please
deploy: chore(main): release 0.8.0 (#689)
4fff9c8 
🤖 I have created a release *beep* *boop*
---

##
[0.8.0](v0.7.0...v0.8.0)
(2025-07-02)

### ⚠ BREAKING CHANGES

* **postgres,mssql,cloudsqlmssql:** encode source connection url for
sources ([#727](#727))

### Features

* Add support for multiple YAML configuration files
([#760](#760))
([40679d7](40679d7))
* Add support for optional parameters
([#617](#617))
([4827771](4827771)),
closes [#475](#475)
* **mcp:** Support MCP version 2025-03-26
([#755](#755))
([474df57](474df57))
* **sources/http:** Support disable SSL verification for HTTP Source
([#674](#674))
([4055b0c](4055b0c))
* **tools/bigquery:** Add templateParameters field for bigquery
([#699](#699))
([f5f771b](f5f771b))
* **tools/bigtable:** Add templateParameters field for bigtable
([#692](#692))
([1c06771](1c06771))
* **tools/couchbase:** Add templateParameters field for couchbase
([#723](#723))
([9197186](9197186))
* **tools/http:** Add support for HTTP Tool pathParams
([#726](#726))
([fd300dc](fd300dc))
* **tools/redis:** Add Redis Source and Tool
([#519](#519))
([f0aef29](f0aef29))
* **tools/spanner:** Add templateParameters field for spanner
([#691](#691))
([075dfa4](075dfa4))
* **tools/sqlitesql:** Add templateParameters field for sqlitesql
([#687](#687))
([75e254c](75e254c))
* **tools/valkey:** Add Valkey Source and Tool
([#532](#532))
([054ec19](054ec19))

### Bug Fixes

* **bigquery,mssql:** Fix panic on tools with array param
([#722](#722))
([7a6644c](7a6644c))
* **postgres,mssql,cloudsqlmssql:** Encode source connection url for
sources ([#727](#727))
([67964d9](67964d9)),
closes [#717](#717)
* Set default value to field's type during unmarshalling
([#774](#774))
([fafed24](fafed24)),
closes [#771](#771)
* **server/mcp:** Do not listen from port for stdio
([#719](#719))
([d51dbc7](d51dbc7)),
closes [#711](#711)
* **tools/mysqlexecutesql:** Handle nil panic and connection leak in
Invoke ([#757](#757))
([7badba4](7badba4))
* **tools/mysqlsql:** Handle nil panic and connection leak in invoke
([#758](#758))
([cbb4a33](cbb4a33))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan <[email protected]> f13e963
github-actions bot pushed a commit to renovate-bot/googleapis-_-genai-toolbox that referenced this pull request Jul 2, 2025
@renovate-bot @release-please
deploy: chore(main): release 0.8.0 (googleapis#689)
12797d9 
🤖 I have created a release *beep* *boop*
---

##
[0.8.0](googleapis/genai-toolbox@v0.7.0...v0.8.0)
(2025-07-02)

### ⚠ BREAKING CHANGES

* **postgres,mssql,cloudsqlmssql:** encode source connection url for
sources ([googleapis#727](googleapis#727))

### Features

* Add support for multiple YAML configuration files
([googleapis#760](googleapis#760))
([40679d7](googleapis@40679d7))
* Add support for optional parameters
([googleapis#617](googleapis#617))
([4827771](googleapis@4827771)),
closes [googleapis#475](googleapis#475)
* **mcp:** Support MCP version 2025-03-26
([googleapis#755](googleapis#755))
([474df57](googleapis@474df57))
* **sources/http:** Support disable SSL verification for HTTP Source
([googleapis#674](googleapis#674))
([4055b0c](googleapis@4055b0c))
* **tools/bigquery:** Add templateParameters field for bigquery
([googleapis#699](googleapis#699))
([f5f771b](googleapis@f5f771b))
* **tools/bigtable:** Add templateParameters field for bigtable
([googleapis#692](googleapis#692))
([1c06771](googleapis@1c06771))
* **tools/couchbase:** Add templateParameters field for couchbase
([googleapis#723](googleapis#723))
([9197186](googleapis@9197186))
* **tools/http:** Add support for HTTP Tool pathParams
([googleapis#726](googleapis#726))
([fd300dc](googleapis@fd300dc))
* **tools/redis:** Add Redis Source and Tool
([googleapis#519](googleapis#519))
([f0aef29](googleapis@f0aef29))
* **tools/spanner:** Add templateParameters field for spanner
([googleapis#691](googleapis#691))
([075dfa4](googleapis@075dfa4))
* **tools/sqlitesql:** Add templateParameters field for sqlitesql
([googleapis#687](googleapis#687))
([75e254c](googleapis@75e254c))
* **tools/valkey:** Add Valkey Source and Tool
([googleapis#532](googleapis#532))
([054ec19](googleapis@054ec19))

### Bug Fixes

* **bigquery,mssql:** Fix panic on tools with array param
([googleapis#722](googleapis#722))
([7a6644c](googleapis@7a6644c))
* **postgres,mssql,cloudsqlmssql:** Encode source connection url for
sources ([googleapis#727](googleapis#727))
([67964d9](googleapis@67964d9)),
closes [googleapis#717](googleapis#717)
* Set default value to field's type during unmarshalling
([googleapis#774](googleapis#774))
([fafed24](googleapis@fafed24)),
closes [googleapis#771](googleapis#771)
* **server/mcp:** Do not listen from port for stdio
([googleapis#719](googleapis#719))
([d51dbc7](googleapis@d51dbc7)),
closes [googleapis#711](googleapis#711)
* **tools/mysqlexecutesql:** Handle nil panic and connection leak in
Invoke ([googleapis#757](googleapis#757))
([7badba4](googleapis@7badba4))
* **tools/mysqlsql:** Handle nil panic and connection leak in invoke
([googleapis#758](googleapis#758))
([cbb4a33](googleapis@cbb4a33))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan <[email protected]> f13e963
duwenxin99 pushed a commit that referenced this pull request Jul 2, 2025
@release-please @Yuan325 @duwenxin99
chore(main): release 0.8.0 (#689)
b931572 
🤖 I have created a release *beep* *boop*
---


##
[0.8.0](v0.7.0...v0.8.0)
(2025-07-02)


### ⚠ BREAKING CHANGES

* **postgres,mssql,cloudsqlmssql:** encode source connection url for
sources ([#727](#727))

### Features

* Add support for multiple YAML configuration files
([#760](#760))
([40679d7](40679d7))
* Add support for optional parameters
([#617](#617))
([4827771](4827771)),
closes [#475](#475)
* **mcp:** Support MCP version 2025-03-26
([#755](#755))
([474df57](474df57))
* **sources/http:** Support disable SSL verification for HTTP Source
([#674](#674))
([4055b0c](4055b0c))
* **tools/bigquery:** Add templateParameters field for bigquery
([#699](#699))
([f5f771b](f5f771b))
* **tools/bigtable:** Add templateParameters field for bigtable
([#692](#692))
([1c06771](1c06771))
* **tools/couchbase:** Add templateParameters field for couchbase
([#723](#723))
([9197186](9197186))
* **tools/http:** Add support for HTTP Tool pathParams
([#726](#726))
([fd300dc](fd300dc))
* **tools/redis:** Add Redis Source and Tool
([#519](#519))
([f0aef29](f0aef29))
* **tools/spanner:** Add templateParameters field for spanner
([#691](#691))
([075dfa4](075dfa4))
* **tools/sqlitesql:** Add templateParameters field for sqlitesql
([#687](#687))
([75e254c](75e254c))
* **tools/valkey:** Add Valkey Source and Tool
([#532](#532))
([054ec19](054ec19))


### Bug Fixes

* **bigquery,mssql:** Fix panic on tools with array param
([#722](#722))
([7a6644c](7a6644c))
* **postgres,mssql,cloudsqlmssql:** Encode source connection url for
sources ([#727](#727))
([67964d9](67964d9)),
closes [#717](#717)
* Set default value to field's type during unmarshalling
([#774](#774))
([fafed24](fafed24)),
closes [#771](#771)
* **server/mcp:** Do not listen from port for stdio
([#719](#719))
([d51dbc7](d51dbc7)),
closes [#711](#711)
* **tools/mysqlexecutesql:** Handle nil panic and connection leak in
Invoke ([#757](#757))
([7badba4](7badba4))
* **tools/mysqlsql:** Handle nil panic and connection leak in invoke
([#758](#758))
([cbb4a33](cbb4a33))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

---------

Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Yuan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kurtisvg kurtisvg kurtisvg approved these changes

Assignees

@kurtisvg kurtisvg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Special characters not working as mssql password
2 participants
@Yuan325 @kurtisvg