Skip to content

fix(transport/http): Add user agent to request headers #3050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 5, 2025
Merged

fix(transport/http): Add user agent to request headers #3050

merged 1 commit into from
Mar 5, 2025

Conversation

@enocom
Copy link
Member

@enocom enocom commented Mar 5, 2025

Fixes #3049

@enocom enocom requested a review from a team as a code owner March 5, 2025 18:36
@enocom
Copy link
Member Author

enocom commented Mar 5, 2025 •
edited
Loading

Because the NewClient function returns an *http.Client with the http.RoundTripper interface, there's no good way to test this change without a much larger update to the tests, which is out of scope for a 1-off fix.

@codyoss codyoss added the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 10cb1ef into googleapis:main Mar 5, 2025
4 of 5 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Mar 5, 2025
@release-please release-please bot mentioned this pull request Mar 5, 2025
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Mar 6, 2025
@release-please
chore(main): release 0.224.0 (#3039)
92f5723 
🤖 I have created a release *beep* *boop*
---


## [0.224.0](https://togithub.com/googleapis/google-api-go-client/compare/v0.223.0...v0.224.0) (2025-03-06)


### Features

* **all:** Auto-regenerate discovery clients ([#3038](https://togithub.com/googleapis/google-api-go-client/issues/3038)) ([e50dbcf](https://togithub.com/googleapis/google-api-go-client/commit/e50dbcf236706c31864e9dac2da4b8553ace321a))
* **all:** Auto-regenerate discovery clients ([#3040](https://togithub.com/googleapis/google-api-go-client/issues/3040)) ([3acb9e0](https://togithub.com/googleapis/google-api-go-client/commit/3acb9e0eb5ba64ab2d628cfb72ae9b6455123cba))
* **all:** Auto-regenerate discovery clients ([#3041](https://togithub.com/googleapis/google-api-go-client/issues/3041)) ([3795b39](https://togithub.com/googleapis/google-api-go-client/commit/3795b39b8e9788eaacb43d3a89681995a9571719))
* **all:** Auto-regenerate discovery clients ([#3042](https://togithub.com/googleapis/google-api-go-client/issues/3042)) ([7d1e850](https://togithub.com/googleapis/google-api-go-client/commit/7d1e8505fd427beceba3fa3a8fe82ecfa8c57d5c))
* **all:** Auto-regenerate discovery clients ([#3043](https://togithub.com/googleapis/google-api-go-client/issues/3043)) ([eaeb698](https://togithub.com/googleapis/google-api-go-client/commit/eaeb698cbdc350788d93599f4454468dece92d00))
* **all:** Auto-regenerate discovery clients ([#3048](https://togithub.com/googleapis/google-api-go-client/issues/3048)) ([0f2af0f](https://togithub.com/googleapis/google-api-go-client/commit/0f2af0f23b3bb2fc6f0edb153b947a27e15be9be))
* **all:** Auto-regenerate discovery clients ([#3051](https://togithub.com/googleapis/google-api-go-client/issues/3051)) ([f10c130](https://togithub.com/googleapis/google-api-go-client/commit/f10c130e16796c008f2e129322d5c8b366ecfc92))


### Bug Fixes

* **transport/http:** Add user agent to request headers ([#3050](https://togithub.com/googleapis/google-api-go-client/issues/3050)) ([10cb1ef](https://togithub.com/googleapis/google-api-go-client/commit/10cb1efd864c1d70ef596d6331951c063eaf00da)), refs [#3049](https://togithub.com/googleapis/google-api-go-client/issues/3049)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

transport/http: User agent is ignored

2 participants

@enocom @codyoss