chore(deps): update googleapis digest to e50da27#16015
chore(deps): update googleapis digest to e50da27#16015renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine update of the Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the googleapis dependency to a newer commit. The change itself is a standard dependency bump. My review includes one suggestion to improve the maintainability of the dependency definition in bazel/workspace0.bzl by refactoring the duplicated commit SHA into a variable. This would make future manual updates safer and easier, reducing the risk of build breakages.
bazel/workspace0.bzl
Outdated
| "https://github.com/googleapis/googleapis/archive/c83d354f79b02e3dc98f22248e22851fcf9b961d.tar.gz", | ||
| ], | ||
| sha256 = "daf93e1331c16fab7606828bcdc92aa72160718de0819eb628fae9922ccaadfc", | ||
| strip_prefix = "googleapis-edfe7983b9d99d6244b4d7636d25fa6e752a2041", | ||
| sha256 = "0be31168e2f38d0e076c518286256522406e622f25d3457125fa168facc34ed5", | ||
| strip_prefix = "googleapis-c83d354f79b02e3dc98f22248e22851fcf9b961d", |
There was a problem hiding this comment.
The googleapis commit SHA is duplicated in the urls and strip_prefix attributes. This makes manual updates error-prone. To improve maintainability and align with the Don't Repeat Yourself (DRY) principle, consider defining this SHA as a variable and reusing it in both places.
For example, you could define a variable within the gl_cpp_workspace0 function scope:
_GOOGLEAPIS_COMMIT = "c83d354f79b02e3dc98f22248e22851fcf9b961d"And then use it in the http_archive definition:
urls = [
"https://github.com/googleapis/googleapis/archive/" + _GOOGLEAPIS_COMMIT + ".tar.gz",
],
# ...
strip_prefix = "googleapis-" + _GOOGLEAPIS_COMMIT,This would make future updates, especially manual ones, less susceptible to copy-paste errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16015 +/- ##
=======================================
Coverage 92.63% 92.63%
=======================================
Files 2333 2333
Lines 214631 214631
=======================================
+ Hits 198827 198831 +4
+ Misses 15804 15800 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
f3249e7 to
e91daae
Compare
|
/gcbrun |
e91daae to
bab5a40
Compare
|
/gcbrun |
bab5a40 to
c27b6a4
Compare
|
/gcbrun |
c27b6a4 to
555026e
Compare
|
/gcbrun |
555026e to
293f741
Compare
|
/gcbrun |
This PR contains the following updates:
edfe798→e50da27Configuration
📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.