chore(deps): update dependency google_cloud_cpp to v2.47.0#16016
chore(deps): update dependency google_cloud_cpp to v2.47.0#16016renovate-bot wants to merge 1 commit intogoogleapis:mainfrom
Conversation
|
/gcbrun |
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request performs a routine dependency update for Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the google_cloud_cpp dependency from v2.42.0 to v2.47.0. The version and hash updates are applied correctly across multiple WORKSPACE.bazel files. However, this highlights a maintainability issue: the dependency definition is duplicated in at least six files, which goes against the repository's style guide. I've added a suggestion to centralize this definition to simplify future updates.
| http_archive( | ||
| name = "google_cloud_cpp", | ||
| sha256 = "699955112a4c57ae9111fbadeff1698674a1762acd77daf36360e6dfc227dc93", | ||
| strip_prefix = "google-cloud-cpp-2.42.0", | ||
| url = "https://github.com/googleapis/google-cloud-cpp/archive/v2.42.0.tar.gz", | ||
| sha256 = "2ed084223c8b156426311c6fd9dde7722fa251a4f24f58e34e0d62150ac3717b", | ||
| strip_prefix = "google-cloud-cpp-2.47.0", | ||
| url = "https://github.com/googleapis/google-cloud-cpp/archive/v2.47.0.tar.gz", | ||
| ) |
There was a problem hiding this comment.
This http_archive definition for google_cloud_cpp is duplicated in at least 6 WORKSPACE.bazel files. This makes maintenance more difficult, as evidenced by this PR where the same change needs to be applied in multiple places. This also violates the repository's style guide regarding code duplication.
To improve maintainability, consider factoring this dependency definition into a single, centralized location. Since these are quickstart examples that should be self-contained, one approach is to define the dependency in a separate .bzl file and fetch it using http_archive. This would centralize the definition while keeping the quickstarts independently runnable.
References
- The repository style guide states a preference for factoring out duplicated code if it appears 3 or more times in non-test files. The
http_archiveblock forgoogle_cloud_cppis duplicated across multiple files, violating this guideline. (link)
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16016 +/- ##
==========================================
- Coverage 92.64% 92.64% -0.01%
==========================================
Files 2333 2333
Lines 214631 214631
==========================================
- Hits 198846 198835 -11
- Misses 15785 15796 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
2 participants
This PR contains the following updates:
v2.42.0→v2.47.0Release Notes
googleapis/google-cloud-cpp (google_cloud_cpp)
v2.47.0Compare Source
New Libraries
We are happy to announce the following GA libraries. Unless specifically noted,
the APIs in these libraries are stable, and are ready for production use.
Spanner
Storage
Google APIs interface definitions
v2.46.0Compare Source
Spanner
Storage
Google APIs interface definitions
v2.45.0Compare Source
New Libraries
We are happy to announce the following GA libraries. Unless specifically noted,
the APIs in these libraries are stable, and are ready for production use.
Pubsub
Storage
Google APIs interface definitions
v2.44.0Compare Source
BigQueryControl
Bigtable
Spanner
Storage
Common Libraries
Google APIs interface definitions
v2.43.0Compare Source
Storage
Google APIs interface definitions
Configuration
📅 Schedule: Branch creation - Monday through Friday ( * * * * 1-5 ) (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.