feat(storage): add MoveObject method for HNS-enabled buckets #14537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
mahendra-google
changed the title
amanda-tarafa
requested changes
Apr 2, 2025
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.csproj
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClient.MoveObject.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClient.MoveObject.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClient.MoveObject.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1/StorageClient.MoveObject.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Show resolved
Hide resolved
amanda-tarafa
requested changes
Apr 3, 2025
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/StorageFixture.cs
Outdated
Show resolved
Hide resolved
|
This PR is ready for re-review. |
amanda-tarafa
requested changes
Apr 9, 2025
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
apis/Google.Cloud.Storage.V1/Google.Cloud.Storage.V1.IntegrationTests/MoveObjectTest.cs
Outdated
Show resolved
Hide resolved
|
@mahendra-google Can you please rebase this PR on HEAD, your branch is a few commits behind and that's why the "Detect differences" check is failing. Thanks. |
…ient.MoveObject.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…ient.MoveObject.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…ient.MoveObject.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…ient.MoveObject.cs Update apis.json
…onTests/StorageFixture.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…ient.MoveObject.cs Update apis.json
…onTests/MoveObjectTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…onTests/MoveObjectTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…onTests/MoveObjectTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…onTests/MoveObjectTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…onTests/MoveObjectTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
…onTests/MoveObjectTest.cs Co-authored-by: Amanda Tarafa Mas <[email protected]>
Update apis.json Update apis.json
mahendra-google
force-pushed
the
move_object
branch
from
f9f9c0f to
de2d78a
Compare
|
|
This PR is ready for re-review except blank line at 6732 in apis.json. |
This was referenced Apr 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves an object within a bucket with hierarchical namespace enabled. This method uses the moveObject underlying API operation for more flexibility and reliability.