Skip to content

feat(bigquery): load job and external table opts for custom time format, null markers and source column match #12470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat(bigquery): load job and external table opts for custom time format, null markers and source column match #12470

wants to merge 2 commits into from
+135 −4

Conversation

alvarowolfx
Copy link
Contributor

Towards internal b/374142085

@alvarowolfx alvarowolfx requested a review from shollyman June 18, 2025 21:00
@alvarowolfx alvarowolfx requested review from a team as code owners June 18, 2025 21:00
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the BigQuery API. label Jun 18, 2025
shollyman
shollyman previously approved these changes Jun 23, 2025
View reviewed changes
@alvarowolfx alvarowolfx added automerge Merge the pull request once unit tests and other checks pass. and removed breaking change labels Aug 6, 2025
@alvarowolfx
Copy link
Contributor Author

apidiff is complaining that by adding the new field NullMarkers to CSVOptions, which is an array, this makes it not comparable anymore. But I don't think that is considered a breaking change for us. Need to check if we can ignore it on a given PR.

Ignoring internal package cloud.google.com/go/bigquery/internal
Ignoring internal package cloud.google.com/go/bigquery/internal/query
Ignoring internal package cloud.google.com/go/bigquery/internal
Ignoring internal package cloud.google.com/go/bigquery/internal/query
CSVOptions: old is comparable, new is not

@alvarowolfx alvarowolfx requested a review from shollyman August 6, 2025 18:44
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Aug 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shollyman shollyman Awaiting requested review from shollyman

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: bigquery Issues related to the BigQuery API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alvarowolfx @shollyman