testing(internal/kokoro): improve escaping for no-change bailout #12482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the bash operator slightly for the case where we attempt to exit testing earlier if there are no significant changes. I noticed when testing an unrelated change that the error log for this file complains about this line because -z is a unary operator. This change quotes the variable so that the it doesn't get split by the bash test. Sample output where things went wrong: ``` + SIGNIFICANT_CHANGES='bigquery/v2 bigquery/v2/apiv2_smoketests' + '[' -z bigquery/v2 bigquery/v2/apiv2_smoketests ']' github/google-cloud-go/internal/kokoro/presubmit.sh: line 84: [: bigquery/v2: binary operator expected ++ echo 'bigquery/v2 bigquery/v2/apiv2_smoketests' ++ tr ' ' '\n' ++ cut -d/ -f1 ++ tr '\n' ' ' ++ sort -u ++ xargs ls -d + CHANGED_DIRS=bigquery ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the bash operator slightly for the case where we attempt to exit testing earlier if there are no significant changes.
I noticed when testing an unrelated change that the error log for this file complains about this line because -z is a unary operator. This change quotes the variable so that the it doesn't get split by the bash test.
Sample output where things went wrong: