refactor(bigquery/v2): job polling logic #12980
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: bigquery
shollyman
reviewed
Oct 14, 2025
Contributor
shollyman
left a comment
shollyman
left a comment
There was a problem hiding this comment.
I'm still digesting the pattern a bit here.
| } | ||
|
|
||
| // CreateFunc is a function that start/insert a new job in BigQuery. Usually jobs.insert or jobs.query. | ||
| type CreateFunc = func(ctx context.Context, opts []gax.CallOption) (protoreflect.Message, error) |
Contributor
There was a problem hiding this comment.
CreateFunc and WaitFunc are the same type signature. Should you just use a more general type and name (e.g. RPCFunc or something)?
| q.consumeQueryResponse(&bigquerypb.GetQueryResultsResponse{ | ||
| JobReference: res.GetJobReference(), | ||
| }) | ||
| func (q *Query) insertQueryFunc(job *bigquerypb.Job, projectID string, opts []gax.CallOption) internaljob.CreateFunc { |
Contributor
There was a problem hiding this comment.
It feels odd to have this method hanging off the outer message and the inner field referencing it as part of its constructor. I wonder if we're missing a chance for a better signature for the new handler function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split job polling logic, so later we can have a generic job vs query package to help execute and wait for jobs.
Towards #12877