Skip to content

chore: librarian unspecified pull request: 20251016T085231Z #13164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

chore: librarian unspecified pull request: 20251016T085231Z #13164

wants to merge 1 commit into from

Conversation

@chingor13
Copy link
Contributor

@chingor13 chingor13 commented Oct 16, 2025

feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-prod/images-prod/librarian-go@sha256:a272fe1ca4fba0c579426dd16fdbb0cac7795fae318292696aa59f801598d431

The following libraries failed to regenerate:

  • auth
  • auth/oauth2adapt
  • compute/metadata
  • pubsub
  • pubsub/v2

@chingor13
feat: update image to us-central1-docker.pkg.dev/cloud-sdk-librarian-…
925fa67 
…prod/images-prod/librarian-go@sha256:a272fe1ca4fba0c579426dd16fdbb0cac7795fae318292696aa59f801598d431
@chingor13
Copy link
Contributor Author

chingor13 commented Oct 16, 2025

One or more libraries have failed to generate, please review PR description for a list of failed libraries.
For each failed library, open a ticket in that library’s repository and then you may resolve this comment and merge.

@chingor13 chingor13 requested a review from a team as a code owner October 16, 2025 15:52
@shollyman
Copy link
Contributor

shollyman commented Oct 16, 2025

tagging @quartzmo on this one for now

@chingor13
Copy link
Contributor Author

chingor13 commented Oct 16, 2025

This is a test, not quite ready yet

@chingor13 chingor13 marked this pull request as draft October 16, 2025 16:01
@chingor13 chingor13 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 16, 2025
@chingor13 chingor13 mentioned this pull request Oct 16, 2025
Merged
@chingor13
Copy link
Contributor Author

chingor13 commented Oct 16, 2025

The PR title "unspecified" part should be already fixed in the source PR

@jskeet
Copy link
Contributor

jskeet commented Oct 16, 2025

It looks like this is running generate on libraries that don't have any APIs. That would at least explain the first four - but pubsub/v2 should generate.

@chingor13
Copy link
Contributor Author

chingor13 commented Oct 16, 2025 •
edited
Loading

It looks like this is running generate on libraries that don't have any APIs. That would at least explain the first four - but pubsub/v2 should generate.

Ah, missed that clause in the generate command. Will update in the update-image command as well. (fixed in googleapis/librarian@d40083b)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@quartzmo quartzmo

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chingor13 @shollyman @jskeet @quartzmo