feat(pubsub/v2): add max callbacks setting to subscriber #13273
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially used in issue #10437, this introduces the ability to set the number of simultaneous callbacks independent of
MaxOutstandingMessages.In general, it makes sense that the number of callbacks should be equal to the number of messages held by the client (which is the number of messages
delivered by the server), the latter of which is predominantly enforced by server side flow control.
There are some cases where it makes sense for these values to differ:
Callbacks > server side flow control
Users may need to have an additional buffer to process messages that exceed flow control. This might be because they are using multiple
streams and flow control is currently set per stream.
Callbacks < server side flow control
Sometimes users want to pull messages early, but restrict the number of callbacks. This could result in fewer network calls in the
form of
stream.Read().Note: When the messages are pulled early this way but not invoked, the timer for the message ack expiration of the
message continues to tick.
It would be best to ensure that the extra pulled messages are processed fast to avoid message expiration.