feat(internal/librariangen): prototype of handling go-genproto #13277
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@quartzmo This is a prototype, but I really want to refactor it if we want to go ahead.
My vision for this would be to have steps of:
We'd then have a separate package for each "type" of repo (default (monorepo+gax+gapic generator), genproto - later the discovery libraries potentially) which would expose the appropriate functions.
I think that would disentangle things more clearly, but it's quite a bit of work, so I didn't want to start on it yet. It's easy to end up with circular dependencies between packages if we're not careful.
I do wonder whether we could put all of the initial parts (parsing the command line, parsing and validating the request, loading the repo config) into a single "main" package, to avoid having a lot of single-file packages. We could have packages of:
Does that sound plausible? (I suspect we'll want an actual design doc for this before going further, and potentially think about how this might work with moving the code into the librarian repo - what parts of it would be cross-language.)