fix(storage): Handle StartResumableWrite errors correctly. #13278
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When StartResumableWrite errors, we were setting an interface to a nil with the implementation type. This uses an intermediate variable, and only assigns to the interface if there was no error.
product-auto-label
bot
added
the
api: storage
Contributor
Author
|
This probably requires a new release branch (v1.56.4?) |
BrennaEpp
approved these changes
Oct 31, 2025
Contributor
|
Looks good to me but I think you'll have to re-open the PR against a new branch in origin. Do you have permission to create one? If not I can do it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When StartResumableWrite errors, we were setting an interface to a nil with the implementation type. This uses an intermediate variable, and only assigns to the interface if there was no error.