-
Notifications
You must be signed in to change notification settings - Fork 1.5k
chore(internal/librariangen): deliberate breaking test change #13288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Summary of ChangesHello @jskeet, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a temporary, deliberate modification to an existing test case. The change is not aimed at fixing a bug or adding new features, but rather to intentionally cause a test to fail. This serves as an internal chore, likely for verifying the robustness and correct reporting of automated checks or CI/CD pipelines. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a change to a test case that appears to be intentionally designed to fail, as indicated by the title and description. The modification changes an expected value in the TestGetModuleConfig test, which will cause a test failure. My review comment identifies this breaking change and suggests a correction to make the test pass, assuming the intent is to have correct and passing tests.
| moduleName: "spanner", | ||
| want: &ModuleConfig{ | ||
| Name: "spanner", | ||
| Name: "spannerx", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The expected Name for the module spanner has been changed to spannerx. This will cause the test case present in config to fail, as the GetModuleConfig function is expected to return a configuration matching the input module name. While the pull request description suggests this may be intentional, this change introduces a failing test into the codebase.
| Name: "spannerx", | |
| Name: "spanner", |
This should create a failed check.