Skip to content

Conversation

@quartzmo
Copy link
Member

No description provided.

@quartzmo quartzmo requested review from a team as code owners November 25, 2025 23:28
@gemini-code-assist
Copy link
Contributor

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

This repository contains the Cloud Client Libraries for Go.

* **Primary Distinction:** This repo contains both **hand-written** (or hybrid) clients and **auto-generated** (GAPIC) clients.
* **Generated Code:** The majority of top-level directories (e.g., `aiplatform`, `secretmanager`, `kms`) are auto-generated GAPIC clients.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to include some clues about where the code is generated from (e.g. "generated by ...")? Ideally an agent would figure out that to make a change in secretmanager they need to go change some other module or repo.

* **Primary Distinction:** This repo contains both **hand-written** (or hybrid) clients and **auto-generated** (GAPIC) clients.
* **Generated Code:** The majority of top-level directories (e.g., `aiplatform`, `secretmanager`, `kms`) are auto-generated GAPIC clients.
* **Do not edit these manually** to fix logic bugs, as changes will be overwritten.
* Only edit them if you are debugging the generation process itself.
Copy link

@westarle westarle Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Optional, to be more clear about their use.

Suggested change
* Only edit them if you are debugging the generation process itself.
* They are useful if you need to review or test the output of the generation process, or if you need to integrate with specific services.
* Only edit them if you are prototyping changes to the generation process.


* **Primary Distinction:** This repo contains both **hand-written** (or hybrid) clients and **auto-generated** (GAPIC) clients.
* **Generated Code:** The majority of top-level directories (e.g., `aiplatform`, `secretmanager`, `kms`) are auto-generated GAPIC clients.
* **Do not edit these manually** to fix logic bugs, as changes will be overwritten.
Copy link

@westarle westarle Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we don't enumerate folders, help by giving some kind of cue.

Suggested change
* **Do not edit these manually** to fix logic bugs, as changes will be overwritten.
* **Do not edit these manually** to fix logic bugs, as changes will be overwritten.
* **Identification:** Always check the first 5 lines for a "Code generated by..." header

@westarle
Copy link

The clear distinction between generated (GAPIC) and hand-written code is excellent. This is a very important piece of context for an AI in this repository -- it might prevent the common failure mode of reading a billion files into context and changing immutable, auto-generated files.

@westarle
Copy link

You could test this by asking something like "I found a bug in aiplatform/gapic_client.go, please fix it."

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants