perf(all): optimize string builder operations

[12ya]

without creating a copy with fmt.Sprintf, writing directly to buffer

[gemini-code-assist]

Summary of Changes

Hello @12ya, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on optimizing string building within the codebase by replacing instances of fmt.Sprintf with fmt.Fprintf to directly write to buffers. Additionally, it modernizes string manipulation by using strings.Cut instead of strings.Index in one instance. These changes aim to improve performance and code readability.

Highlights

• Optimization: Replaced fmt.Sprintf with fmt.Fprintf to write directly to the buffer, avoiding unnecessary string copies.
• Code Modernization: Replaced strings.Index with strings.Cut for improved readability and potential performance benefits.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request correctly optimizes string building by replacing sb.WriteString(fmt.Sprintf(...)) with fmt.Fprintf(&sb, ...), which avoids an intermediate string allocation. The changes look good overall. I've found one potential bug where a change from strings.Index to strings.Cut alters the existing logic, which I've flagged as critical. I've also added several suggestions for further micro-optimizations to the string building logic, which you might find useful given the goal of this PR.