feat(auth): add OpenTelemetry gRPC and HTTP wrappers for T4 tracing#14133
feat(auth): add OpenTelemetry gRPC and HTTP wrappers for T4 tracing#14133quartzmo merged 19 commits intogoogleapis:mainfrom
Conversation
Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics. refs: googleapis/gax-go#472 refs: googleapis/gapic-generator-go#1706
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces OpenTelemetry wrappers for gRPC and HTTP transports to enhance tracing with Google Cloud-specific attributes. The changes include feature-gating the new functionality, adding static attributes from options, and dynamically adding attributes from the request context. The implementation correctly handles error semantics for spans. The accompanying tests are thorough, covering both enabled and disabled states of the new tracing feature. My review includes suggestions to improve performance by batching attribute updates and to make the tests more robust by avoiding reliance on test names for test setup.
westarle
left a comment
westarle
left a comment
There was a problem hiding this comment.
A lot of nits about field names and sources, structurally I think this is good (and protected by the feature flag.)
quartzmo
added
the
do not merge
|
Adding |
quartzmo
removed
the
do not merge
|
Removed |
4 participants
Enable grpctransport and httptransport to inject static attributes, capture dynamic attributes from context, and enforce error semantics.
refs: googleapis/gax-go#472
refs: googleapis/gapic-generator-go#1706