fix(firestore): Replace legacy header google-cloud-resource-prefix with x-goog-request-params
#24490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use -- conventional-commit-lint bot |
SandeepTuniki
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
SandeepTuniki
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
SandeepTuniki
changed the title
google-cloud-resource-prefix with x-goog-request-params
SandeepTuniki
added
the
do not merge
product-auto-label
bot
added
the
api: firestore
|
The backend now accepts the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR replaces the legacy header
google-cloud-resource-prefixwith the preferred headerx-goog-request-params. See this (internal) for more info.Note: Firestore doesn't yet accept the header value of
x-goog-request-paramsin the formatprojects/{project_id/databases/{database_id}. So this PR shouldn't be merged until the backend release (see here).