Sample(storage): Soft deleted Bucket Restore #28760
Conversation
shubhangi-google
force-pushed
the
soft_deleted_bucket_restore_with_sample
branch
2 times, most recently
from
0085055 to
4bdeb8b
Compare
|
Please ignore ci issues in this PR for now, This Pr is for tracking sample failures |
bajajneha27
added
the
kokoro:run
| let(:new_bucket_name) { random_bucket_name } | ||
|
|
||
| it "get soft deleted bucket, its soft_delete_time and hard_delete_time" do | ||
| new_bucket = storage_client.create_bucket new_bucket_name |
There was a problem hiding this comment.
Does this new bucket have soft_delete_policy ?
If not, we won't be able to recover the bucket.
There was a problem hiding this comment.
@bajajneha27 on console I can see this for one of the ruby sample test bucket
There was a problem hiding this comment.
Is the soft_delete_policy set by default if you create a new bucket?
If not, you'll have to pass it while creating the new bucket.
There was a problem hiding this comment.
yes this is set by default
There was a problem hiding this comment.
Hmmm. Can you explicitly check the policy in test too, so that we're sure we've the policy in place.
There was a problem hiding this comment.
@bajajneha27 tried to set retention period for the bucket explicitly but getting same result
also I can see in this doc (https://cloud.google.com/storage/docs/soft-delete#retention-duration) that default soft deleted policy is set as 7 days for a bucket
There was a problem hiding this comment.
@shubhangi-google , the retention_period that you tried to set in this test is not related to soft delete policy, it's related to retention_policy. These are two different things. See here
I think you can try
- Setting soft delete policy explicitly, to make sure the bucket has soft deletion enabled. This PR has example of how you can set soft_delete_policy.
- Check if soft delete policy is actually set.
- Then try fetch the soft deleted bucket.
There was a problem hiding this comment.
still getting same issue @bajajneha27
bajajneha27
added
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
…_restore_with_sample' into soft_deleted_bucket_restore_with_sample
| # fetching bucket | ||
| check_bucket = storage_client.bucket new_bucket_name | ||
| puts "new bucket name-- #{check_bucket.name}" | ||
| puts "new bucket soft_delete_policy-- #{check_bucket.soft_delete_policy}" |
There was a problem hiding this comment.
soft_delete_policy is nil ?
If the policy is nil then that means it's not a soft deleted bucket. You need to make sure of that first.
There was a problem hiding this comment.
soft deleted policy is not coming as nil
see the log
new bucket soft_delete_policy-- #<Google::Apis::StorageV1::Bucket::SoftDeletePolicy:0x00007fc1c733a4b0
we have also checked in test case for the presence of soft deleted policy here https://github.com/googleapis/google-cloud-ruby/pull/28760/files#diff-038ec9ce9ebab1eb9b210c6691a04076bd29214c57b349651b409951341ab908R132
There was a problem hiding this comment.
we have also checked in test case for the presence of soft deleted policy here https://github.com/googleapis/google-cloud-ruby/pull/28760/files#diff-038ec9ce9ebab1eb9b210c6691a04076bd29214c57b349651b409951341ab908R132
That's for new_bucket. Since you just added the policy to the same object, it'll show the value .
soft deleted policy is not coming as nil see the log new bucket soft_delete_policy-- #<Google::Apis::StorageV1::Bucket::SoftDeletePolicy:0x00007fc1c733a4b0
I don't see this in kokoro samples log. Sending the screenshot offline.
There was a problem hiding this comment.
You can try two things:
- Enable the DEBUG log to see if your soft_delete_policy is actually being set via the HTTP call. [Sending the command offline]
- Try setting the soft_delete_policy using the object:
soft_delete_policy = Google::Apis::StorageV1::Bucket::SoftDeletePolicy.new
soft_delete_policy.retention_duration_seconds = 10*24*60*60
bucket.soft_delete_policy = soft_delete_policy
Add support for restoring soft deleted bucket.
Operation Supported: