Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(generator/protobuf): larger golden files #155

Merged

Conversation

coryan
Copy link
Contributor

@coryan coryan commented Nov 11, 2024

Part of the work for #150

@coryan coryan marked this pull request as ready for review November 11, 2024 22:23
@coryan coryan requested a review from codyoss November 11, 2024 22:23
@codyoss
Copy link
Member

codyoss commented Nov 12, 2024

Note this is the second copy of these protos checked into this repo now. This one without Iam for simplicity I assume in generation. We should eventually remove this copy.

@coryan
Copy link
Contributor Author

coryan commented Nov 12, 2024

Note this is the second copy of these protos checked into this repo now. This one without Iam for simplicity I assume in generation. We should eventually remove this copy.

Ack, and agreed.

@coryan coryan merged commit 389d33f into googleapis:main Nov 12, 2024
10 checks passed
@coryan coryan deleted the test-generator-protobuf-larger-golden-files branch November 12, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants