test(generator/rust): add IAM RPCs to golden files #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Include the IAM RPCs in the Rust golden files. We need one patch to workaround the `GetIamPolicy()` query parameters.
codyoss
approved these changes
Nov 14, 2024
| option (google.api.http) = { | ||
| get: "/v1/{resource=projects/*/secrets/*}:getIamPolicy" | ||
| // TODO(#158) - this is not in the protos from GitHub | ||
| body: "*" |
There was a problem hiding this comment.
nit: per https://google.aip.dev/127 Gets don't have body.
There was a problem hiding this comment.
Ack, though:
Maybe we need to special case GetIamPolicy()?
There was a problem hiding this comment.
Opened #181 to discuss. Merging.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Include the IAM RPCs in the Rust golden files. We need one patch to
workaround the
GetIamPolicy()query parameters.Part of the work for #158