refactor(storage): avoid include! macro
#2755
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2755 +/- ##
=======================================
Coverage 95.50% 95.50%
=======================================
Files 96 96
Lines 4092 4092
=======================================
Hits 3908 3908
Misses 184 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Jul 23, 2025
| @@ -25,3 +25,5 @@ pub mod stub; | |||
|
|
|||
| mod convert; | |||
| mod status; | |||
|
|
|||
There was a problem hiding this comment.
without the blank line it bugged me that they were not in alphabetical order.
and if I put them in alphabetical order, it bugged me that the generated mod was sandwiched between handwritten mods. 🤷
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Avoid using the
include!macro which gives us formatting, and makes the source code lookup-able in the docs. Thanks @coryan for the suggestion.