impl(storage): read_object() retries at start
#2759
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: storage
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2759 +/- ##
==========================================
+ Coverage 95.31% 95.33% +0.02%
==========================================
Files 95 95
Lines 3928 3947 +19
==========================================
+ Hits 3744 3763 +19
Misses 184 184 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Weave the retry options into the `read_object()` builder, so we can at least retry the initial request. Resuming interrupted downloads will come in a future PR.
coryan
force-pushed
the
impl-storage-retry-download-start
branch
from
562be23 to
6e4bee2
Compare
dbolduc
previously approved these changes
Jul 24, 2025
dbolduc
approved these changes
Jul 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Weave the retry options into the
read_object()builder, so we can at leastretry the initial request. Resuming interrupted downloads will come in a future PR.
Part of the work for #2048