feat: Add support for async token getters to ToolboxTool #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kurtisvg
requested changes
Apr 4, 2025
Absolutely, I will add these in an upcoming PR for unit tests (#150 ) |
A best practice is to include tests for features when they merge. Unless we have extenuating circumstances, let's try to follow that. |
anubhav756
force-pushed
the
anubhav-async-auth-callable
branch
2 times, most recently
from
0bcceb4 to
0724e38
Compare
That's a good idea. Unit tests added. Thanks! |
anubhav756
force-pushed
the
anubhav-tests
branch
3 times, most recently
from
d11b5d4 to
7038c1d
Compare
anubhav756
force-pushed
the
anubhav-async-auth-callable
branch
from
0724e38 to
081dcf4
Compare
|
Looks great! Do you mind adding an e2e test for this functionality? |
anubhav756
force-pushed
the
anubhav-async-auth-callable
branch
from
081dcf4 to
05c881a
Compare
anubhav756
force-pushed
the
anubhav-tests
branch
from
cd1d6a2 to
d3e20e5
Compare
anubhav756
force-pushed
the
anubhav-async-auth-callable
branch
from
a65149c to
c80fadc
Compare
twishabansal
approved these changes
Apr 14, 2025
twishabansal
requested changes
Apr 15, 2025
twishabansal
approved these changes
Apr 15, 2025
anubhav756
added a commit
that referenced
this pull request
Apr 16, 2025
* dep: Add pytest-cov package as a test dependency. * chore: Remove unused imports from sync_client.py * chore: Add unit tests for the tool and client classes * chore: Delint * chore: Delint * chore: Cover tool not found case * chore: Add toolbox tool unit test cases * chore: Add additional test cases to cover tool invocation and better docstring validation. * chore: Add test cases for sync and static bound parameter. * chore: Reorder tests in matching classes. This will improve maintainability. * feat: Add support for async token getters to ToolboxTool (#147) * feat: Add support for async token getters to ToolboxTool * chore: Improve variable names and docstring for more clarity * chore: Improve docstring * chore: Add unit test cases * chore: Add e2e test case * chore: Fix e2e test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were only supporting sync token getters. Adding support for async getters could be beneficial performance-wise.