Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add comment that pagination happens automatically #1427

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

alvarowolfx
Copy link
Contributor

Towards internal b/373431246

@alvarowolfx alvarowolfx requested review from a team as code owners November 12, 2024 18:06
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigquery Issues related to the googleapis/nodejs-bigquery API. labels Nov 12, 2024
@@ -33,6 +33,7 @@ function main() {
const [job] = await bigquery.createQueryJob(query);

// Wait for job to complete and get rows.
// The client library automatically handles pagination.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// The client library automatically handles pagination.
// The client library automatically handles pagination.
// See more info at https://github.com/googleapis/gax-nodejs/blob/main/client-libraries.md#auto-pagination for more information on how to configure paging calls

Copy link
Contributor

@leahecole leahecole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a suggestion

@alvarowolfx alvarowolfx added the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 14, 2024
@alvarowolfx alvarowolfx added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Nov 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Nov 14, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit 04784d2 into googleapis:main Nov 14, 2024
14 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquery Issues related to the googleapis/nodejs-bigquery API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants