Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove ipython core private import #5000

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jhpierce
Copy link

@jhpierce jhpierce commented Mar 4, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Get the necessary approvals
  • Once the last commit on the PR has been approved, add the "ready to pull" label to the Pull Request

Note: do not merge your PR from GitHub. Adding the "ready to pull" label is the final step in the review process.
After approvals, the changes in your PR will be committed to the main branch and this PR will be closed.

Fixes #4999 🦕

@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: vertex-ai Issues related to the googleapis/python-aiplatform API. labels Mar 4, 2025
@jhpierce jhpierce force-pushed the jhp/fix-ipython-display-usage branch from f012362 to 373d64b Compare March 4, 2025 04:49
@jhpierce jhpierce marked this pull request as ready for review March 4, 2025 13:37
@jhpierce jhpierce force-pushed the jhp/fix-ipython-display-usage branch from 4e4fa57 to 9488537 Compare March 11, 2025 15:08
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Mar 11, 2025
@jhpierce jhpierce force-pushed the jhp/fix-ipython-display-usage branch from 9488537 to 7c2fe52 Compare March 11, 2025 15:14
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. and removed size: m Pull request size is medium. labels Mar 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: vertex-ai Issues related to the googleapis/python-aiplatform API. size: xs Pull request size is extra small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPython v9 removed a private member that is being imported
1 participant