Skip to content

fix: Some suggestions to enhance some of the code #2172

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: Some suggestions to enhance some of the code #2172

wants to merge 1 commit into from

Conversation

chalmerlowe
Copy link
Collaborator

@chalmerlowe chalmerlowe commented May 2, 2025 •
edited
Loading

I am suggesting several ideas to enhance some of the code in PR 2171:

  • remove duplicate code
  • mirror existing usage patterns (elsewhere we tend to set query_params = {} instead of None)
  • Revise spelling

@chalmerlowe chalmerlowe requested review from a team as code owners May 2, 2025 18:56
@chalmerlowe chalmerlowe requested review from suzmue and removed request for a team May 2, 2025 18:56
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label May 2, 2025
@product-auto-label product-auto-label bot added the api: bigquery Issues related to the googleapis/python-bigquery API. label May 2, 2025
@chalmerlowe chalmerlowe assigned chalmerlowe and unassigned tswast May 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suzmue suzmue Awaiting requested review from suzmue suzmue is a code owner automatically assigned from googleapis/api-bigquery

Assignees

@chalmerlowe chalmerlowe

Labels
api: bigquery Issues related to the googleapis/python-bigquery API. size: s Pull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chalmerlowe @tswast