lint fixes

googleapis · Nov 15, 2024 · b5067da · b5067da
1 parent 6cea495
commit b5067da
Showing 1 changed file with 13 additions and 13 deletions.
diff --git a/tests/unit/test_pool.py b/tests/unit/test_pool.py
@@ -221,7 +221,7 @@ def test_spans_bind_get(self):
         pool.bind(database)
 
         with trace_call("pool.Get", SESSIONS[0]) as span:
-            session = pool.get()
+            pool.get()
             wantEventNames = [
                 "Acquiring session",
                 "Waiting for a session to become available",
@@ -250,7 +250,7 @@ def test_spans_get_create_sessions(self):
         database._sessions.extend(SESSIONS)
         try:
             pool.bind(database)
-        except Exception as e:
+        except Exception:
             pass
 
         wantEventNames = [
@@ -413,7 +413,7 @@ def test_spans_get_empty_pool(self):
         database._sessions.append(session1)
         pool.bind(database)
 
-        with trace_call("pool.Get", session1) as span:
+        with trace_call("pool.Get", session1):
             session = pool.get()
             self.assertIsInstance(session, _Session)
             self.assertIs(session._database, database)
@@ -450,7 +450,7 @@ def test_spans_get_non_empty_session_exists(self):
         database = _Database("name")
         previous = _Session(database)
         pool.bind(database)
-        with trace_call("pool.Get", previous) as span:
+        with trace_call("pool.Get", previous):
             pool.put(previous)
             session = pool.get()
             self.assertIs(session, previous)
@@ -496,7 +496,7 @@ def test_spans_put_empty(self):
         pool.bind(database)
         session = _Session(database)
 
-        with trace_call("pool.put", session) as span:
+        with trace_call("pool.put", session):
             pool.put(session)
             self.assertFalse(pool._sessions.empty())
 
@@ -524,7 +524,7 @@ def test_spans_put_full(self):
         database = _Database("name")
         pool.bind(database)
         older = _Session(database)
-        with trace_call("pool.put", older) as span:
+        with trace_call("pool.put", older):
             pool.put(older)
             self.assertFalse(pool._sessions.empty())
 
@@ -839,10 +839,10 @@ def test_spans_get_empty_pool(self):
         database._sessions.append(session1)
         try:
             pool.bind(database)
-        except:
+        except Exception:
             pass
 
-        with trace_call("pool.Get", session1) as span:
+        with trace_call("pool.Get", session1):
             session = pool.get()
             self.assertIsInstance(session, _Session)
             self.assertIs(session._database, database)
@@ -1069,13 +1069,13 @@ def test_spans_get_empty_pool(self):
         database._sessions.append(session1)
         try:
             pool.bind(database)
-        except:
+        except Exception:
             pass
 
-        with trace_call("pool.Get", session1) as span:
+        with trace_call("pool.Get", session1):
             try:
-                session = pool.get()
-            except:
+                pool.get()
+            except Exception:
                 pass
 
             self.assertTrue(pool._sessions.empty())
@@ -1171,7 +1171,7 @@ def __init__(self, database, exists=True, transaction=None):
         self._deleted = False
         self._transaction = transaction
         # Generate a faux id.
-        self._session_id = f"time.time()"
+        self._session_id = f"{time.time()}"
 
     def __lt__(self, other):
         return id(self) < id(other)