feat: Add maxBatchingDelayMs Option. #987
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
harshachinta
reviewed
Aug 3, 2023
| @@ -145,9 +146,14 @@ def _check_state(self): | |||
| if self.committed is not None: | |||
| raise ValueError("Batch already committed") | |||
|
|
|||
| def commit(self, return_commit_stats=False, request_options=None): | |||
| def commit(self, max_batching_delay_ms=None, return_commit_stats=False, request_options=None): | |||
There was a problem hiding this comment.
Adding new argument max_batching_delay_ms as second parameter might break any existing applications that have not used key explicitly while calling commit.
Can we move this to end?
Suggested change
| def commit(self, max_batching_delay_ms=None, return_commit_stats=False, request_options=None): | |
| def commit(self, return_commit_stats=False, request_options=None, max_batching_delay_ms=None): |
@surbhigarg92 Can you please correct me this is incorrect?
harshachinta
reviewed
Aug 3, 2023
| @@ -182,11 +188,16 @@ def commit(self, return_commit_stats=False, request_options=None): | |||
| # Request tags are not supported for commit requests. | |||
| request_options.request_tag = None | |||
|
|
|||
| Duration max_batching_delay = None | |||
| if max_batching_delay_ms is not None: | |||
| max_batching_delay.nanos = 1000000 * [max_batching_delay_ms] | |||
There was a problem hiding this comment.
How is this default decided?
harshachinta
reviewed
Aug 3, 2023
| @@ -180,9 +181,14 @@ def rollback(self): | |||
| self.rolled_back = True | |||
| del self._session._transaction | |||
|
|
|||
| def commit(self, return_commit_stats=False, request_options=None): | |||
| def commit(self, max_batching_delay_ms=None, return_commit_stats=False, request_options=None): | |||
|
@nginsberg-google Do we need this PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for max batching delay option in Commit requests.
This feature allows users to express how much latency they are willing for spanner to add to attempt to batch their writes. Generally speaking, the more latency they are willing to tolerate, the more efficiently Spanner can serve the writes.